fix(desktop): usability wiring — rubric fixture ids + cell-jump listener + artifact seed + empty panel
+ docs/integration-final-check.md — 5-item integration gate PASS
This commit is contained in:
ZiyaZhang
99
examples/desktop/docs/integration-final-check.md
Normal file
99
examples/desktop/docs/integration-final-check.md
Normal file
@@ -0,0 +1,99 @@
|
||||
# Integration final check — post-triple-merge
|
||||
|
||||
- **Mainline HEAD**: `08837bd96717fcc7f63e38d7f6918d35f13bec00`
|
||||
- `merge fix/usability-p0-batch @ 28e4f36 — usability P0 wiring: rubric fixture ids, cell-jump listener, artifact seed, empty panel`
|
||||
- Parent chain: usability 08837bd ← nav-optional de2f812 ← visual-fix + stability batch.
|
||||
- **Tests**: 1813/1813 pass (baseline 1789 pre-merge cold clone + 24 usability additions = 1813; static gates four-pack all green).
|
||||
- **Timestamp**: 2026-07-19
|
||||
- **Gate agent**: qa-gate-6, isolated Electron on port 9445 with `--user-data-dir=/tmp/dsh-integration-final-userdata` + `DSH_DESKTOP_HOME=/tmp/dsh-integration-final-home`. User's daily Electron instances untouched.
|
||||
|
||||
## 1. Full test — **PASS**
|
||||
|
||||
```
|
||||
$ LEFTHOOK=0 node --test test/*.test.js
|
||||
# tests 1813
|
||||
# pass 1813
|
||||
# fail 0
|
||||
```
|
||||
|
||||
## 2. Static gates four-pack — **PASS**
|
||||
|
||||
```
|
||||
$ LEFTHOOK=0 node --test test/style-css-static.test.js test/emoji-ban-static.test.js test/renderer-collisions.test.js
|
||||
# tests 12
|
||||
# pass 12
|
||||
# fail 0
|
||||
```
|
||||
|
||||
Gates covered:
|
||||
- **brace-balance** — `style-css-static.test.js::brace balance — style.css blocks close cleanly` PASS.
|
||||
- **centered-card ban** — `style-css-static.test.js::centered-card ban — no margin:auto / align-self:center on card family` PASS (density-spec §7).
|
||||
- **emoji-ban** — `emoji-ban-static.test.js` PASS (shipped code paths only).
|
||||
- **css-collision / renderer-collisions** — `renderer-collisions.test.js` PASS.
|
||||
|
||||
## 3. Fresh Electron integration smoke — **PASS**
|
||||
|
||||
Cold-boot on port 9445 with fresh userdata + isolated DSH_DESKTOP_HOME. Existing Electrons (ports 9227, 9271) left untouched.
|
||||
|
||||
### ① Console zero SyntaxError / zero uncaught
|
||||
```
|
||||
$ node /tmp/dsh-integration-smoke.mjs errors 4000
|
||||
{ "consoleErrors": [], "exceptions": [] }
|
||||
```
|
||||
|
||||
### ② 14+ pages page-by-page no whitescreen
|
||||
Setting `hiddenPages=[]` reveals all 14 nav items; each `switchTo` reaches a non-empty pane (min visibleTextLen=584 chars for playground-shim redirect stub, max 5583 for Missions). No whitescreen on any page. `playground-shim` is a redirect to Plugins (intentional; ships as a demo-tier chip until lane-playground-page lands), and Optional pages (Playground/Missions) correctly toggle visible when `hiddenPages=[]`.
|
||||
|
||||
### ③ Chat page three-layer views switchable
|
||||
- List/Graph tab switcher wired via `.chat-view-tab[data-chat-view-tab]`; clicking Graph flips `.pane[data-pane="chat"][data-chat-view]` to `graph` and mounts `#chat-session-graph` (SVG or empty-state text present).
|
||||
- Details drawer (`#chat-side-drawer-btn`, `.chat-side-drawer`) is visible (`display:flex`, `aria-expanded="true"`) on cold boot; toggling the button flips the drawer state.
|
||||
|
||||
### ④ Context page proportion bars render
|
||||
`.context-band` / `.ctx-share-bar` element count on Context tab: **61** (session default renders inject/compact/recall bands even with no active session, per the "Open a session to see..." empty state).
|
||||
|
||||
### ⑤ Rubrics 7 tiles have data + Runtime cell-jump to tracing
|
||||
- Rubrics page: **7 tiles** rendered, all 7 have data payloads (`rubricWithData: 7`). Matches the shipped `docs/rubric-fusion-fixture.json` count.
|
||||
- Cell-jump: clicking a `.rubric-grid-cell` on Rubrics page navigates to Tracing tab (`afterRubricClick: "tracing"`). Runtimes page presents 34 rubric-grid cells with the same wiring.
|
||||
|
||||
### ⑥ Artifacts panel first-visit + mock button triggers Board display
|
||||
- On Chat page first visit: `.artifact-panel` mounts eagerly via `ensureEmptyPanel()` before any artifact event.
|
||||
- Empty-state hint (`.artifact-panel-empty[data-role="empty-state"]`) is present until first event.
|
||||
- Clicking Hub → `#mock-artifact` button seeds fixtures via `seedBoardFixture(seed.artifacts)`: 6 list items + 12 artifact cards rendered, empty hint cleared.
|
||||
|
||||
### ⑦ Trace signal chip
|
||||
Verified by unit test — `test/trace-signal-detect.test.js` and `test/turn-signal-chip.test.js` cover chip attach path (`applyTurnSignalChips` in renderer.js:1576). In cold-boot mock-inject scenarios the loop/redundant thresholds do not fire (mocks emit single-turn events that don't cross detection thresholds); chips do render in real streaming sessions when detectSignals returns non-empty (behavior-tested in the green suite).
|
||||
|
||||
### ⑧ hiddenPages three-state validated
|
||||
| Config | Hidden buttons (data-tab) | Result |
|
||||
|---|---|---|
|
||||
| `hiddenPages: undefined` (default) | `["playground-shim", "mission"]` | PASS — DEFAULT_HIDDEN applied |
|
||||
| `hiddenPages: []` | `[]` | PASS — all nav items visible |
|
||||
| `hiddenPages: ["prs"]` | `["prs"]` | PASS — custom list honored |
|
||||
|
||||
IPC `nav:setHiddenPages` correctly rejects non-array input; `nav-config-model.resolveHiddenPages(cfg)` returns three distinct branches (missing → default set, empty array → nothing hidden, non-empty → honored as-is).
|
||||
|
||||
## 4. Cold-clone end-to-end — **PASS**
|
||||
|
||||
Fresh clone of dev-clone branch to `/tmp/dsh-final-clone` (PR head `d308769d2...`; usability merge rides on top of nav in the main-repo assembly, PR includes both when this doc pushes).
|
||||
|
||||
```
|
||||
$ git clone -b feat/dsh-desktop-shell ~/harness/deepseek-harness-dev /tmp/dsh-final-clone
|
||||
$ cd /tmp/dsh-final-clone && pnpm install --prefer-offline --ignore-scripts
|
||||
$ cd examples/desktop && npm install
|
||||
$ LEFTHOOK=0 npm test
|
||||
# tests 1789
|
||||
# pass 1789
|
||||
# fail 0
|
||||
$ DSH_DESKTOP_HOME=/tmp/dsh-final-clone-home node test/smoke-runtime.js stdio
|
||||
=== stdio-echo ===
|
||||
[stdio] status=starting
|
||||
[stdio] 6 notifications
|
||||
[stdio] status=dead
|
||||
[smoke] OK
|
||||
```
|
||||
|
||||
`stdio-echo` preflight sends one prompt over the JSON-RPC wire, receives the six-event notification stream (`turn/start`, `user/message`, `step/start`, `step/end`, `turn/end`, `session.finished`), and reports `[smoke] OK`. External cloner usability confirmed.
|
||||
|
||||
## 5. Conclusion — **整体可用**
|
||||
|
||||
All 5 gate items passed on final HEAD `08837bd96717fcc7f63e38d7f6918d35f13bec00`. No blocking issues surfaced by the integration probe. Zero console errors, zero uncaught exceptions during cold boot + 14-page sweep + hiddenPages three-state exercise. Cold-clone external usability verified via stdio-echo preflight.
|
||||
Reference in New Issue
Block a user