fix(web): clarify wildcard host safety warning
This commit is contained in:
@@ -67,7 +67,7 @@ export function apply(ctx: Context): void {
|
|||||||
program.action(() => {
|
program.action(() => {
|
||||||
const options = program.opts<WebOptions>()
|
const options = program.opts<WebOptions>()
|
||||||
if (options.host === '0.0.0.0') {
|
if (options.host === '0.0.0.0') {
|
||||||
program.error('error: --host 0.0.0.0 is intentionally not supported yet; use 127.0.0.1 instead')
|
program.error('error: --host 0.0.0.0 is intentionally not supported yet for safety: it would expose remote code execution to the network; use 127.0.0.1 instead')
|
||||||
}
|
}
|
||||||
if (options.port !== undefined && !/^\d+$/.test(options.port)) {
|
if (options.port !== undefined && !/^\d+$/.test(options.port)) {
|
||||||
program.error(`error: --port must be a number, got ${JSON.stringify(options.port)}`)
|
program.error(`error: --port must be a number, got ${JSON.stringify(options.port)}`)
|
||||||
|
|||||||
@@ -131,7 +131,7 @@ describe('web command-line provider', () => {
|
|||||||
|
|
||||||
it('rejects the intentionally unsupported all-interfaces host before the consumer activates', async () => {
|
it('rejects the intentionally unsupported all-interfaces host before the consumer activates', async () => {
|
||||||
const { values, observed } = await bootProvider(['--host', '0.0.0.0'])
|
const { values, observed } = await bootProvider(['--host', '0.0.0.0'])
|
||||||
expect(observed.out).toContain('--host 0.0.0.0 is intentionally not supported yet; use 127.0.0.1 instead')
|
expect(observed.out).toContain('--host 0.0.0.0 is intentionally not supported yet for safety: it would expose remote code execution to the network; use 127.0.0.1 instead')
|
||||||
expect(values).toBeUndefined()
|
expect(values).toBeUndefined()
|
||||||
expect(observed.readerConfig).toBeUndefined()
|
expect(observed.readerConfig).toBeUndefined()
|
||||||
expect(observed.exits).toEqual([1])
|
expect(observed.exits).toEqual([1])
|
||||||
|
|||||||
Reference in New Issue
Block a user