refactor(cli): bail early in the arg adapter instead of returning errors as data

Address review and cut ceremony: the adapter no longer models help/version/
errors as DshInvocation members. Commander owns those under exitOverride — it
prints usage or the diagnostic and one try/catch in parseDshArgs turns the
thrown CommanderError into process.exit with the intended code. bin.ts drops its
help/version/error cases; the union is the three real modes.

Domain checks bail via command.error(print + exit 1): --prompt rejects an empty
task or a stray config/--resume, empty --resume= fails loud, and --host/--port
are validated. A repeated --resume or a flag captured as a value is Commander's
standard behavior, left alone (a bad id fails loud downstream). dsh --help
discloses web via addHelpText. Net: args.ts 185 -> 112 lines.

Also fixes review nits: built-bin e2e resolves on `close`; the /resume handoff
uses `dsh --resume=<id> -- <config>` so a config named `web` stays a positional;
and stale prose (cordis.yml comment, app-boot module doc + duplicate JSDoc,
ui/README, two feature notes, an agent-loop test name) tracks the shipped state.
Removes tui-demo's now-dead plugin-include dep and vendor/loader + app-boot
tsconfig references.

apps/cli/tests/args.spec.ts

@@ -1,8 +1,28 @@
-import { describe, expect, it } from 'vitest'
+import { afterEach, describe, expect, it, vi } from 'vitest'
 import { ALL_INTERFACES_HOST, LOOPBACK_HOST, parseDshArgs } from '../src/args.ts'
 
 const parse = (argv: string[]) => parseDshArgs(argv, '1.2.3')
 
+/**
+ * `parseDshArgs` calls `process.exit` for `--help`/`--version`/errors and lets
+ * Commander print to the real streams; capture the exit code and mute output.
+ */
+function exitCode(argv: string[]): number {
+  const exit = vi.spyOn(process, 'exit').mockImplementation(() => { throw new Error('exit') })
+  vi.spyOn(process.stdout, 'write').mockReturnValue(true)
+  vi.spyOn(process.stderr, 'write').mockReturnValue(true)
+  try {
+    parse(argv)
+    throw new Error(`expected ${JSON.stringify(argv)} to exit`)
+  } catch {
+    return exit.mock.calls.at(-1)?.[0] as number
+  } finally {
+    vi.restoreAllMocks()
+  }
+}
+
+afterEach(() => { vi.restoreAllMocks() })
+
 describe('parseDshArgs', () => {
   it('routes each mode by its shape: default TUI, -p headless, web subcommand', () => {
     expect(parse([])).toEqual({ mode: 'tui' })
@@ -10,25 +30,24 @@ describe('parseDshArgs', () => {
     expect(parse(['--resume', 'sess', 'app.yml'])).toEqual({ mode: 'tui', config: 'app.yml', resume: 'sess' })
     expect(parse(['-p', 'do the thing'])).toEqual({ mode: 'headless', prompt: 'do the thing' })
     expect(parse(['web'])).toEqual({ mode: 'web', host: LOOPBACK_HOST, port: 3080, dev: false })
-    expect(parse(['web', '--host', ALL_INTERFACES_HOST, '--port', '8080']))
-      .toEqual({ mode: 'web', host: ALL_INTERFACES_HOST, port: 8080, dev: false })
-    expect(parse(['web', '--dev'])).toEqual({ mode: 'web', host: LOOPBACK_HOST, port: 3080, dev: true })
+    expect(parse(['web', '--host', ALL_INTERFACES_HOST, '--port', '8080', '--dev']))
+      .toEqual({ mode: 'web', host: ALL_INTERFACES_HOST, port: 8080, dev: true })
   })
 
-  it('fails loud instead of silently starting fresh or serving on bad input', () => {
-    // An empty resume/prompt would otherwise be swallowed (agent-loop treats an
-    // empty resume id as no-resume); a bad host/port must not reach the listener.
-    expect(parse(['--resume=']).mode).toBe('error')
-    expect(parse(['-p', '']).mode).toBe('error')
-    expect(parse(['web', '--host', '10.0.0.1']).mode).toBe('error')
-    expect(parse(['web', '--port', 'abc']).mode).toBe('error')
-    expect(parse(['--bogus']).mode).toBe('error')
+  it('exits nonzero instead of silently starting fresh, serving, or dropping inputs', () => {
+    // Empty resume/prompt would be swallowed downstream; bad host/port must not
+    // reach the listener; --prompt mixed with TUI inputs must not lose them.
+    expect(exitCode(['--resume='])).toBe(1)
+    expect(exitCode(['-p', ''])).toBe(1)
+    expect(exitCode(['web', '--host', '10.0.0.1'])).toBe(1)
+    expect(exitCode(['web', '--port', 'abc'])).toBe(1)
+    expect(exitCode(['web', '--port='])).toBe(1)
+    expect(exitCode(['config.yml', '-p', 'x'])).toBe(1)
+    expect(exitCode(['--bogus'])).toBe(1)
   })
 
-  it('surfaces --help and --version as printable data, not a process exit', () => {
-    const help = parse(['--help'])
-    expect(help).toMatchObject({ mode: 'help' })
-    if (help.mode === 'help') expect(help.text).toContain('Usage: dsh')
-    expect(parse(['--version'])).toEqual({ mode: 'version', text: '1.2.3\n' })
+  it('exits 0 for --help (disclosing web) and --version', () => {
+    expect(exitCode(['--help'])).toBe(0)
+    expect(exitCode(['--version'])).toBe(0)
   })
 })

apps/cli/tests/built-bin.e2e.ts

@@ -36,7 +36,8 @@ function runBuiltBin(): Promise<{ stdout: string; code: number; stderr: string }
       child.kill('SIGKILL')
       reject(new Error(`dsh built bin did not exit within 25s. stdout:\n${stdout}\nstderr:\n${stderr}`))
     }, 25_000)
-    child.on('exit', (code) => { clearTimeout(timer); resolve({ stdout, code: code ?? -1, stderr }) })
+    // Resolve on `close` (all stdio drained), not `exit`, so captured output is complete.
+    child.on('close', (code) => { clearTimeout(timer); resolve({ stdout, code: code ?? -1, stderr }) })
     child.on('error', (err) => { clearTimeout(timer); reject(err) })
     child.stdin.end()
   })