Files
aurum/backend/app/services/crypto_service.py
ZProger bd97e316cc fix: сортировать активы в «Криптовалюте» по вложенной сумме
Монеты в таблице активов шли в алфавитном порядке (сортировка по
имени в SQL-запросе) — с импортированными портфелями это выглядело
хаотично. Теперь список отсортирован по cost basis (сколько денег
реально вложено в монету) от большего к меньшему; полностью
проданная позиция уходит в конец списка, а не в начало.
2026-09-04 02:26:37 +03:00

699 lines
30 KiB
Python

"""Crypto price sync + position accounting: CoinGecko Demo API calls,
written into the *existing* Asset/AssetValuation engine (see
models/asset.py) rather than a parallel value-tracking system. A holding's
value is an ordinary AssetValuation row, so Net Worth, reports, and
everything else that already walks Asset rows needs zero changes to treat a
crypto holding like any other manually tracked asset.
Quantity and average buy price are never stored — they're derived from the
CryptoTransaction log every time (see _compute_position), the same
"you record it, we derive it" shape as Goal/GoalContribution.
Refreshes are deliberately never automatic in the background — same
reasoning as recurring transactions (see services/recurring_service.py):
there's no scheduler/worker in this stack, and a rate-limited free API key
makes "poll constantly" actively counterproductive anyway. Three triggers
only: the "Refresh prices" button (force=True), a lazy once-a-day check
that piggybacks on GET /crypto/holdings (force=False), and adding a brand
new holding (a one-off seed fetch, justified by the explicit user action).
Editing quantity via a buy/sell transaction never calls CoinGecko — it
reuses the last cached price.
"""
import asyncio
from datetime import date as date_
from datetime import datetime, timedelta, timezone
from decimal import Decimal
from itertools import groupby
from typing import Literal, NamedTuple
import httpx
from fastapi import HTTPException
from sqlalchemy import select
from sqlalchemy.dialects.postgresql import insert as pg_insert
from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.orm import selectinload
from app.core.config import get_settings
from app.models.asset import Asset, AssetValuation
from app.models.crypto import CryptoHolding, CryptoPortfolio, CryptoSyncState, CryptoTransaction
from app.models.enums import AssetClass, CapitalRole, CryptoTransactionType, RiskLevel
from app.schemas.crypto import (
CryptoHistoryPoint,
CryptoHistoryResponse,
CryptoHoldingCreate,
CryptoHoldingRead,
CryptoPerformancePoint,
CryptoPerformanceResponse,
CryptoPortfolioCreate,
CryptoPortfolioRead,
CryptoPortfolioUpdate,
CryptoSearchResult,
CryptoSyncResult,
CryptoTransactionCreate,
CryptoTransactionUpdate,
)
from app.services.settings_service import get_or_create_app_settings
# Same 8-hue, colorblind-safe categorical set app/db/seed.py assigns default
# categories from — reused here (cycling by creation order) so portfolio tab
# dots are visually distinct out of the box, with no manual color picker to
# build for a v1 feature.
PORTFOLIO_PALETTE = [
"#2a78d6",
"#eb6834",
"#1baf7a",
"#eda100",
"#e87ba4",
"#008300",
"#4a3aa7",
"#e34948",
]
COINGECKO_BASE_URL = "https://api.coingecko.com/api/v3"
# CoinGecko's own Demo-tier data only refreshes every 60s server-side
# (see docs.coingecko.com/reference/simple-price) — polling more often than
# once a day here buys nothing and only spends rate-limit budget for no
# reason (see module docstring on why there's no background poller at all).
AUTO_REFRESH_INTERVAL = timedelta(hours=24)
# Deliberately no "24h" option, unlike Net Worth's own RANGE_DAYS — our price
# history is only ever as dense as our sync cadence (at most a few points a
# day, see AUTO_REFRESH_INTERVAL above), so a 24h chart would show one or
# two points, not the smooth intraday line a denser data source could draw.
CRYPTO_RANGE_DAYS: dict[str, int] = {"7d": 7, "30d": 30, "90d": 90}
_EAGER = (selectinload(CryptoHolding.transactions),)
def _require_api_key() -> str:
api_key = get_settings().coingecko_api_key
if not api_key:
raise HTTPException(
status_code=400,
detail=(
"CoinGecko API key not configured — set AURUM_COINGECKO_API_KEY in .env "
"(free Demo key, no card required: coingecko.com/en/api/pricing)."
),
)
return api_key
class _MarketPoint(NamedTuple):
price: Decimal
change_1h: Decimal | None
change_24h: Decimal | None
change_7d: Decimal | None
# Defaulted so existing call sites/tests built before these two existed
# don't have to name them. 1y stands in for "all time" on the Best/Worst
# Performer stat (see get_90d_performance's docstring on why 90d alone
# needs a different, on-demand code path).
change_30d: Decimal | None = None
change_1y: Decimal | None = None
def _decimal_or_none(value: object) -> Decimal | None:
return Decimal(str(value)) if value is not None else None
async def _fetch_market_data(coingecko_ids: list[str], vs_currency: str) -> dict[str, _MarketPoint]:
"""One CoinGecko call for every tracked coin at once (up to 250 ids per
/coins/markets call) — never one call per coin, that's what would
actually burn through a free-tier rate limit. Also returns 1h/24h/7d/30d/1y
% change in the same call, so this fully replaces a separate
/simple/price lookup. (90d isn't offered here at all — CoinGecko's own
supported windows skip straight from 30d to 200d; see
get_90d_performance for how the Crypto tab's 90d Best/Worst Performer
view is computed instead.)"""
if not coingecko_ids:
return {}
api_key = _require_api_key()
async with httpx.AsyncClient(timeout=10.0) as client:
response = await client.get(
f"{COINGECKO_BASE_URL}/coins/markets",
params={
"vs_currency": vs_currency,
"ids": ",".join(coingecko_ids),
"price_change_percentage": "1h,24h,7d,30d,1y",
},
headers={"x-cg-demo-api-key": api_key},
)
response.raise_for_status()
data = response.json()
points: dict[str, _MarketPoint] = {}
for coin in data:
price = _decimal_or_none(coin.get("current_price"))
if price is None:
continue
points[coin["id"]] = _MarketPoint(
price=price,
change_1h=_decimal_or_none(coin.get("price_change_percentage_1h_in_currency")),
change_24h=_decimal_or_none(coin.get("price_change_percentage_24h_in_currency")),
change_7d=_decimal_or_none(coin.get("price_change_percentage_7d_in_currency")),
change_30d=_decimal_or_none(coin.get("price_change_percentage_30d_in_currency")),
change_1y=_decimal_or_none(coin.get("price_change_percentage_1y_in_currency")),
)
return points
async def search_coins(query: str) -> list[CryptoSearchResult]:
"""Backs the "add a coin" picker — the whole reason a user can find the
right coingecko_id without knowing it by heart, same as typing a name
into CoinMarketCap's own search box."""
api_key = _require_api_key()
async with httpx.AsyncClient(timeout=10.0) as client:
response = await client.get(
f"{COINGECKO_BASE_URL}/search",
params={"query": query},
headers={"x-cg-demo-api-key": api_key},
)
response.raise_for_status()
data = response.json()
return [
CryptoSearchResult(
coingecko_id=coin["id"],
symbol=str(coin["symbol"]).upper(),
name=coin["name"],
thumb_url=coin.get("thumb"),
)
for coin in data.get("coins", [])[:20]
]
def _compute_position(transactions: list[CryptoTransaction]) -> tuple[Decimal, Decimal | None]:
"""Weighted-average-cost method, replayed over the transaction log in
date order: a BUY blends into the running average cost; a SELL reduces
quantity but leaves the average cost of what's still held unchanged —
selling some coins doesn't retroactively change what you paid for the
ones you kept. Returns (quantity, avg_buy_price); avg_buy_price is None
once quantity hits zero (nothing left to have a cost basis)."""
quantity = Decimal("0")
avg_price: Decimal | None = None
for tx in sorted(transactions, key=lambda t: (t.date, t.id)):
if tx.type == CryptoTransactionType.BUY:
existing_cost = (avg_price or Decimal("0")) * quantity
quantity += tx.quantity
avg_price = (existing_cost + tx.price_per_unit * tx.quantity) / quantity if quantity else None
else:
quantity -= tx.quantity
if quantity <= 0:
quantity = Decimal("0")
avg_price = None
return quantity, avg_price
def _to_read(holding: CryptoHolding) -> CryptoHoldingRead:
quantity, avg_buy_price = _compute_position(holding.transactions)
current_price = holding.last_price
value = current_price * quantity if current_price is not None else None
cost_basis = avg_buy_price * quantity if avg_buy_price is not None else None
profit_loss = (value - cost_basis) if value is not None and cost_basis is not None else None
profit_loss_percent = float(profit_loss / cost_basis * 100) if profit_loss is not None and cost_basis else None
return CryptoHoldingRead(
asset_id=holding.asset_id,
portfolio_id=holding.portfolio_id,
coingecko_id=holding.coingecko_id,
symbol=holding.symbol,
name=holding.name,
thumb_url=holding.thumb_url,
quantity=quantity,
avg_buy_price=avg_buy_price,
current_price=current_price,
price_change_1h=holding.price_change_1h,
price_change_24h=holding.price_change_24h,
price_change_7d=holding.price_change_7d,
price_change_30d=holding.price_change_30d,
price_change_1y=holding.price_change_1y,
value=value,
cost_basis=cost_basis,
profit_loss=profit_loss,
profit_loss_percent=profit_loss_percent,
)
def _sort_by_invested(reads: list[CryptoHoldingRead]) -> list[CryptoHoldingRead]:
"""Biggest cost basis (money actually put in, not current market value)
first, so the Holdings table reads as "what am I most committed to"
rather than an arbitrary/alphabetical order. A fully-exited position
(cost_basis None — everything's been sold) sorts last, not first: -1 can
never collide with a real cost basis, which is never negative."""
return sorted(reads, key=lambda r: r.cost_basis if r.cost_basis is not None else Decimal("-1"), reverse=True)
def _portfolio_to_read(portfolio: CryptoPortfolio) -> CryptoPortfolioRead:
return CryptoPortfolioRead.model_validate(portfolio)
async def list_portfolios(session: AsyncSession, include_archived: bool) -> list[CryptoPortfolioRead]:
stmt = select(CryptoPortfolio).order_by(CryptoPortfolio.id)
if not include_archived:
stmt = stmt.where(CryptoPortfolio.is_archived.is_(False))
portfolios = (await session.execute(stmt)).scalars().all()
return [_portfolio_to_read(p) for p in portfolios]
async def get_or_create_default_portfolio(session: AsyncSession) -> CryptoPortfolio:
"""The portfolio a new holding lands in when the caller doesn't specify
one (see CryptoHoldingCreate.portfolio_id) — the earliest-created
portfolio, auto-created the first time it's needed. Same self-healing
"create on first use" shape as seed_default_app_settings: a portfolio can
later be deleted once empty (see delete_portfolio), so this can't just
assume row id=1 always exists."""
existing = (
await session.execute(select(CryptoPortfolio).order_by(CryptoPortfolio.id).limit(1))
).scalar_one_or_none()
if existing is not None:
return existing
portfolio = CryptoPortfolio(name="Main Portfolio", color=PORTFOLIO_PALETTE[0])
session.add(portfolio)
await session.flush()
return portfolio
async def create_portfolio(session: AsyncSession, payload: CryptoPortfolioCreate) -> CryptoPortfolioRead:
count = (await session.execute(select(CryptoPortfolio.id))).scalars().all()
color = PORTFOLIO_PALETTE[len(count) % len(PORTFOLIO_PALETTE)]
portfolio = CryptoPortfolio(name=payload.name, color=color)
session.add(portfolio)
await session.commit()
await session.refresh(portfolio)
return _portfolio_to_read(portfolio)
async def update_portfolio(
session: AsyncSession, portfolio_id: int, payload: CryptoPortfolioUpdate
) -> CryptoPortfolioRead:
portfolio = await session.get(CryptoPortfolio, portfolio_id)
if portfolio is None:
raise HTTPException(status_code=404, detail="Crypto portfolio not found")
for field, value in payload.model_dump(exclude_unset=True).items():
setattr(portfolio, field, value)
await session.commit()
await session.refresh(portfolio)
return _portfolio_to_read(portfolio)
async def delete_portfolio(session: AsyncSession, portfolio_id: int) -> None:
portfolio = await session.get(CryptoPortfolio, portfolio_id)
if portfolio is None:
raise HTTPException(status_code=404, detail="Crypto portfolio not found")
has_holding = (
await session.execute(select(CryptoHolding.asset_id).where(CryptoHolding.portfolio_id == portfolio_id).limit(1))
).first()
if has_holding is not None:
raise HTTPException(status_code=400, detail="Move or delete its coins before deleting a portfolio")
await session.delete(portfolio)
await session.commit()
async def list_holdings(session: AsyncSession, portfolio_id: int | None = None) -> list[CryptoHolding]:
stmt = select(CryptoHolding).options(*_EAGER).order_by(CryptoHolding.name)
if portfolio_id is not None:
stmt = stmt.where(CryptoHolding.portfolio_id == portfolio_id)
result = await session.execute(stmt)
return list(result.scalars().all())
async def _get_holding_or_404(session: AsyncSession, asset_id: int) -> CryptoHolding:
result = await session.execute(select(CryptoHolding).options(*_EAGER).where(CryptoHolding.asset_id == asset_id))
holding = result.scalar_one_or_none()
if holding is None:
raise HTTPException(status_code=404, detail="Crypto holding not found")
return holding
async def get_or_create_sync_state(session: AsyncSession) -> CryptoSyncState:
state = await session.get(CryptoSyncState, 1)
if state is None:
state = CryptoSyncState(id=1, last_synced_at=None)
session.add(state)
await session.commit()
await session.refresh(state)
return state
async def _upsert_valuation(session: AsyncSession, asset_id: int, value: Decimal, as_of_date: date_) -> None:
"""Same upsert-by-date pattern as routes/assets.py's POST
/assets/{id}/valuations — re-syncing the same day updates that day's
value instead of erroring. Still needed even though quantity/price
aren't stored on CryptoHolding: Net Worth's whole engine reads this
table, not CryptoHolding, for a coin's value history."""
upsert_stmt = (
pg_insert(AssetValuation)
.values(asset_id=asset_id, value=value, as_of_date=as_of_date)
.on_conflict_do_update(
index_elements=[AssetValuation.asset_id, AssetValuation.as_of_date],
set_={"value": value},
)
)
await session.execute(upsert_stmt)
async def refresh_prices(session: AsyncSession, *, force: bool, portfolio_id: int | None = None) -> CryptoSyncResult:
"""Sync always covers every holding regardless of `portfolio_id` — a
stale price on a coin the user isn't currently looking at would still be
wrong the next time they switch tabs. `portfolio_id` only narrows what's
returned in the response's `holdings` list, for the Crypto tab's
portfolio filter."""
state = await get_or_create_sync_state(session)
now = datetime.now(timezone.utc)
if not force and state.last_synced_at is not None and now - state.last_synced_at < AUTO_REFRESH_INTERVAL:
holdings = await list_holdings(session, portfolio_id)
return CryptoSyncResult(
synced=False, last_synced_at=state.last_synced_at, holdings=_sort_by_invested([_to_read(h) for h in holdings])
)
holdings = await list_holdings(session)
error_key: Literal["unreachable"] | None = None
if holdings:
settings = await get_or_create_app_settings(session)
try:
market_data = await _fetch_market_data([h.coingecko_id for h in holdings], settings.currency.lower())
except httpx.HTTPError:
# CoinGecko down/rate-limited — don't touch last_synced_at (the
# next open of the tab retries) and don't touch any existing
# price/AssetValuation. The tab still shows the last known
# values instead of an empty/broken page over an external outage.
error_key = "unreachable"
else:
today = date_.today()
for holding in holdings:
point = market_data.get(holding.coingecko_id)
if point is None:
continue # coin missing from the response — keep its last known values, don't zero them out
holding.last_price = point.price
holding.price_change_1h = point.change_1h
holding.price_change_24h = point.change_24h
holding.price_change_7d = point.change_7d
holding.price_change_30d = point.change_30d
holding.price_change_1y = point.change_1y
quantity, _ = _compute_position(holding.transactions)
if quantity > 0:
await _upsert_valuation(session, holding.asset_id, quantity * point.price, today)
if error_key is None:
state.last_synced_at = now
await session.commit()
# holdings were mutated in place above (ordinary ORM attribute
# assignment, not a raw Core write) — no need to re-query, they already
# reflect what was just committed.
visible = holdings if portfolio_id is None else [h for h in holdings if h.portfolio_id == portfolio_id]
return CryptoSyncResult(
synced=error_key is None,
last_synced_at=state.last_synced_at,
error_key=error_key,
holdings=_sort_by_invested([_to_read(h) for h in visible]),
)
async def create_holding(session: AsyncSession, payload: CryptoHoldingCreate) -> CryptoHoldingRead:
settings = await get_or_create_app_settings(session)
if payload.portfolio_id is not None:
portfolio = await session.get(CryptoPortfolio, payload.portfolio_id)
if portfolio is None:
raise HTTPException(status_code=400, detail="Crypto portfolio not found")
portfolio_id = portfolio.id
else:
portfolio_id = (await get_or_create_default_portfolio(session)).id
asset = Asset(
name=payload.name,
asset_class=AssetClass.CRYPTO,
currency=settings.currency,
capital_role=CapitalRole.NEUTRAL,
# Defaults to HIGH, not the Asset model's own MEDIUM default — matches
# this app's own risk-level copy, which names crypto as the textbook
# HIGH example (see lib/i18n.ts's netWorth.riskLevelFormHint.high).
risk_level=RiskLevel.HIGH,
)
session.add(asset)
await session.flush()
holding = CryptoHolding(
asset_id=asset.id,
portfolio_id=portfolio_id,
coingecko_id=payload.coingecko_id,
symbol=payload.symbol.upper(),
name=payload.name,
thumb_url=payload.thumb_url,
)
session.add(holding)
holding.transactions.append(
CryptoTransaction(
type=CryptoTransactionType.BUY,
quantity=payload.quantity,
price_per_unit=payload.price_per_unit,
date=payload.date,
note=payload.note,
)
)
await session.flush()
# Seed today's live price immediately — a coin the user just added
# sitting at "no price yet" until tomorrow's auto-sync would be
# confusing, and this one call is clearly justified by an explicit
# user action.
try:
market_data = await _fetch_market_data([payload.coingecko_id], settings.currency.lower())
point = market_data.get(payload.coingecko_id)
if point is not None:
holding.last_price = point.price
holding.price_change_1h = point.change_1h
holding.price_change_24h = point.change_24h
holding.price_change_7d = point.change_7d
holding.price_change_30d = point.change_30d
holding.price_change_1y = point.change_1y
await _upsert_valuation(session, asset.id, payload.quantity * point.price, date_.today())
# This counts as a real sync — bump the shared timestamp so the next
# GET /crypto/holdings doesn't immediately re-fetch every holding
# again a moment later (see refresh_prices' 24h window).
state = await get_or_create_sync_state(session)
state.last_synced_at = datetime.now(timezone.utc)
except httpx.HTTPError:
pass # holding is still created — the next daily/manual sync will price it
await session.commit()
return _to_read(holding)
async def add_transaction(session: AsyncSession, asset_id: int, payload: CryptoTransactionCreate) -> CryptoHoldingRead:
"""A buy or sell against an existing holding — never calls CoinGecko
(see module docstring): value is recomputed from the last cached
price, same principle as the old quantity-only edit it replaces."""
holding = await _get_holding_or_404(session, asset_id)
if payload.type == CryptoTransactionType.SELL:
current_quantity, _ = _compute_position(holding.transactions)
if payload.quantity > current_quantity:
raise HTTPException(status_code=400, detail="Cannot sell more than you currently hold")
holding.transactions.append(
CryptoTransaction(
type=payload.type,
quantity=payload.quantity,
price_per_unit=payload.price_per_unit,
date=payload.date,
note=payload.note,
)
)
await session.flush()
quantity, _ = _compute_position(holding.transactions)
if holding.last_price is not None:
await _upsert_valuation(session, asset_id, quantity * holding.last_price, date_.today())
await session.commit()
return _to_read(holding)
async def update_transaction(
session: AsyncSession, transaction_id: int, payload: CryptoTransactionUpdate
) -> CryptoHoldingRead:
"""Edit an existing buy/sell entry — the "view/edit a transaction" flow
a plain delete-and-recreate can't offer (you'd lose the original id and
any history a future feature might key off it). Never calls CoinGecko,
same as add_transaction: value is recomputed from the last cached price."""
transaction = await session.get(CryptoTransaction, transaction_id)
if transaction is None:
raise HTTPException(status_code=404, detail="Crypto transaction not found")
asset_id = transaction.asset_id
holding = await _get_holding_or_404(session, asset_id)
updates = payload.model_dump(exclude_unset=True)
effective_type = updates.get("type", transaction.type)
effective_quantity = updates.get("quantity", transaction.quantity)
if effective_type == CryptoTransactionType.SELL:
# Same guard as add_transaction, checked against every *other*
# transaction on this holding — editing this one in place must not
# let it sell more than what the rest of the log would leave held.
others = [t for t in holding.transactions if t.id != transaction_id]
quantity_without_this, _ = _compute_position(others)
if effective_quantity > quantity_without_this:
raise HTTPException(status_code=400, detail="Cannot sell more than you currently hold")
for field, value in updates.items():
setattr(transaction, field, value)
await session.flush()
quantity, _ = _compute_position(holding.transactions)
if holding.last_price is not None:
await _upsert_valuation(session, asset_id, quantity * holding.last_price, date_.today())
await session.commit()
return _to_read(holding)
async def list_transactions(session: AsyncSession, asset_id: int) -> list[CryptoTransaction]:
await _get_holding_or_404(session, asset_id) # 404s if the holding itself doesn't exist
result = await session.execute(
select(CryptoTransaction)
.where(CryptoTransaction.asset_id == asset_id)
.order_by(CryptoTransaction.date.desc(), CryptoTransaction.id.desc())
)
return list(result.scalars().all())
async def delete_transaction(session: AsyncSession, transaction_id: int) -> None:
transaction = await session.get(CryptoTransaction, transaction_id)
if transaction is None:
raise HTTPException(status_code=404, detail="Crypto transaction not found")
asset_id = transaction.asset_id
await session.delete(transaction)
await session.flush()
holding = await _get_holding_or_404(session, asset_id)
quantity, _ = _compute_position(holding.transactions)
if holding.last_price is not None:
await _upsert_valuation(session, asset_id, quantity * holding.last_price, date_.today())
await session.commit()
async def get_crypto_history(
session: AsyncSession, range_key: str, portfolio_id: int | None = None
) -> CryptoHistoryResponse:
"""Total crypto holdings value over time, for the History chart on the
Crypto tab. Same "cumulative point events, forward-filled" approach as
net_worth_service.py's own asset series — duplicated here rather than
imported, so this can't destabilize the already-tested Net Worth engine,
and scoped to crypto-class assets only (a deleted holding's
AssetValuation rows are gone via cascade, so its history naturally
drops out here too, same as it already does for Net Worth). Further
scoped to one portfolio's assets when `portfolio_id` is given, for the
Crypto tab's portfolio filter."""
today = date_.today()
asset_stmt = (
select(Asset.id)
.join(CryptoHolding, CryptoHolding.asset_id == Asset.id)
.where(Asset.asset_class == AssetClass.CRYPTO)
)
if portfolio_id is not None:
asset_stmt = asset_stmt.where(CryptoHolding.portfolio_id == portfolio_id)
crypto_asset_ids = set((await session.execute(asset_stmt)).scalars().all())
if not crypto_asset_ids:
return CryptoHistoryResponse(range=range_key, current=Decimal("0"), change_amount=Decimal("0"), change_percent=None, series=[])
valuations = (
await session.execute(
select(AssetValuation.asset_id, AssetValuation.as_of_date, AssetValuation.value)
.where(AssetValuation.asset_id.in_(crypto_asset_ids))
.order_by(AssetValuation.as_of_date)
)
).all()
if not valuations:
return CryptoHistoryResponse(range=range_key, current=Decimal("0"), change_amount=Decimal("0"), change_percent=None, series=[])
current_by_asset: dict[int, Decimal] = {}
events: list[tuple[date_, Decimal]] = []
for day, group in groupby(valuations, key=lambda row: row[1]):
for asset_id, _, value in group:
current_by_asset[asset_id] = value
events.append((day, sum(current_by_asset.values(), Decimal("0"))))
start = today - timedelta(days=CRYPTO_RANGE_DAYS[range_key] - 1) if range_key in CRYPTO_RANGE_DAYS else events[0][0]
points: list[CryptoHistoryPoint] = []
idx, n = 0, len(events)
running = Decimal("0")
day = start
while day <= today:
while idx < n and events[idx][0] <= day:
running = events[idx][1]
idx += 1
points.append(CryptoHistoryPoint(date=day, value=running))
day += timedelta(days=1)
current = points[-1].value if points else Decimal("0")
start_value = points[0].value if points else Decimal("0")
change_amount = current - start_value
change_percent = float(change_amount / start_value * 100) if start_value else None
return CryptoHistoryResponse(
range=range_key,
current=current,
change_amount=change_amount,
change_percent=change_percent,
series=points,
)
async def _fetch_90d_change(client: httpx.AsyncClient, api_key: str, coingecko_id: str, vs_currency: str) -> float | None:
"""A coin's own real price 90 days ago vs now, straight from CoinGecko's
market_chart series — the closest and last point in the returned series,
respectively. Any failure (rate limit, outage, a coin CoinGecko has less
than 90 days of data for) returns None rather than raising: one coin's
hiccup shouldn't blank out every other tile (same "best data on hand"
principle as refresh_prices' own CoinGecko-outage handling)."""
try:
response = await client.get(
f"{COINGECKO_BASE_URL}/coins/{coingecko_id}/market_chart",
params={"vs_currency": vs_currency, "days": 90},
headers={"x-cg-demo-api-key": api_key},
)
response.raise_for_status()
prices = response.json().get("prices", [])
except httpx.HTTPError:
return None
if len(prices) < 2:
return None
first_price, last_price = prices[0][1], prices[-1][1]
if not first_price:
return None
return (last_price - first_price) / first_price * 100
async def get_90d_performance(session: AsyncSession, portfolio_id: int | None) -> CryptoPerformanceResponse:
"""Real 90-day % price change per currently-held coin, for the Crypto
tab's Best/Worst Performer stat when the 90d range is picked. Unlike
1h/24h/7d/30d/1y (all one field on the same batched /coins/markets sync
call, see _fetch_market_data), CoinGecko has no 90-day window on that
endpoint at all — the only way to get it is one market_chart call per
coin, so this is deliberately never part of the regular sync and only
ever runs on an explicit "look at 90d" user action, same justification
as the seed fetch on adding a new holding. Bounded concurrency (5 at
once) keeps a big portfolio from firing dozens of requests in the same
instant."""
holdings = await list_holdings(session, portfolio_id)
held = [h for h in holdings if _compute_position(h.transactions)[0] > 0]
if not held:
return CryptoPerformanceResponse(items=[])
settings = await get_or_create_app_settings(session)
api_key = _require_api_key()
semaphore = asyncio.Semaphore(5)
async def fetch_one(client: httpx.AsyncClient, holding: CryptoHolding) -> CryptoPerformancePoint:
async with semaphore:
change = await _fetch_90d_change(client, api_key, holding.coingecko_id, settings.currency.lower())
return CryptoPerformancePoint(asset_id=holding.asset_id, price_change_percent=change)
async with httpx.AsyncClient(timeout=10.0) as client:
items = await asyncio.gather(*(fetch_one(client, h) for h in held))
return CryptoPerformanceResponse(items=list(items))