mirror of
https://github.com/Zproger/Aurum.git
synced 2026-10-13 11:06:40 +07:00
TransactionRead inherited TransactionBase's model_validator, so the rules a new row must satisfy were also applied on the way out, to rows already in the database. A row can stop satisfying them through no fault of its own: transactions.transfer_account_id is ON DELETE SET NULL, so deleting an account leaves every transfer that pointed at it without a destination. The result was that deleting an account could 500 the entire transactions list — permanently, and with the list gone there was no way in the UI to find and delete the offending row. The fields move to TransactionFields, which reading uses; TransactionBase keeps the invariants for the write path. The frontend already tolerates a missing destination (TransactionsTable renders the transfer suffix only when transfer_account_id is set, and the edit modal makes you pick a destination before saving), so such a row is now visible, editable and deletable instead of fatal.
136 lines
5.0 KiB
Python
136 lines
5.0 KiB
Python
from datetime import date as date_
|
|
from decimal import Decimal
|
|
|
|
from pydantic import BaseModel, ConfigDict, Field, field_validator, model_validator
|
|
|
|
from app.core.text import capitalize_first_letter
|
|
from app.models.enums import TransactionType
|
|
from app.schemas.account import AccountRead
|
|
from app.schemas.category import CategoryRead
|
|
from app.schemas.tag import TagRead
|
|
|
|
|
|
def transfer_rule_violation(
|
|
*,
|
|
type: TransactionType,
|
|
account_id: int,
|
|
transfer_account_id: int | None,
|
|
category_id: int | None,
|
|
) -> str | None:
|
|
"""The transfer invariants in one place, returning the problem as text or
|
|
None if the combination is valid.
|
|
|
|
Both halves of the write path go through this: the create schema below
|
|
(as a pydantic validator) and the PATCH route (see
|
|
routes/transactions.py). Enforcing it on create only used to let an edit
|
|
produce a row that create would have rejected — most damagingly a
|
|
transfer with no transfer_account_id, which TransactionRead itself can't
|
|
serialize, so the row broke every later read of the transactions list.
|
|
"""
|
|
if type == TransactionType.TRANSFER:
|
|
if not transfer_account_id:
|
|
return "transfer_account_id is required for transfer transactions"
|
|
if transfer_account_id == account_id:
|
|
return "transfer_account_id must differ from account_id"
|
|
if category_id:
|
|
return "category_id is not valid for transfer transactions"
|
|
elif transfer_account_id:
|
|
return "transfer_account_id is only valid for transfer transactions"
|
|
return None
|
|
|
|
|
|
class TransactionFields(BaseModel):
|
|
"""A transaction's shape, without the rules that only make sense while
|
|
writing one. Reading goes through this: rows already in the database can
|
|
stop satisfying a write-time rule through no fault of their own — the
|
|
transfer_account_id FK is ON DELETE SET NULL, so deleting an account
|
|
leaves the transfers that pointed at it with no destination — and
|
|
refusing to serialize such a row would take the whole transactions list
|
|
down with it, leaving no way in the UI to find and delete the row."""
|
|
|
|
account_id: int
|
|
category_id: int | None = None
|
|
transfer_account_id: int | None = None
|
|
type: TransactionType
|
|
amount: Decimal = Field(gt=0, max_digits=14, decimal_places=2)
|
|
description: str = Field(min_length=1, max_length=255)
|
|
merchant: str | None = Field(default=None, max_length=150)
|
|
notes: str | None = None
|
|
date: date_
|
|
|
|
# Auto-capitalizes "траты на продукты" -> "Траты на продукты" so mixed
|
|
# casing from quick manual entry doesn't need fixing by hand later.
|
|
@field_validator("description")
|
|
@classmethod
|
|
def _capitalize_description(cls, value: str) -> str:
|
|
return capitalize_first_letter(value)
|
|
|
|
|
|
class TransactionBase(TransactionFields):
|
|
"""The write-side shape: the fields plus the invariants a new or edited
|
|
row has to satisfy."""
|
|
|
|
@model_validator(mode="after")
|
|
def _validate_type_specific_fields(self) -> "TransactionBase":
|
|
violation = transfer_rule_violation(
|
|
type=self.type,
|
|
account_id=self.account_id,
|
|
transfer_account_id=self.transfer_account_id,
|
|
category_id=self.category_id,
|
|
)
|
|
if violation:
|
|
raise ValueError(violation)
|
|
return self
|
|
|
|
|
|
class TransactionCreate(TransactionBase):
|
|
tag_ids: list[int] = Field(default_factory=list)
|
|
|
|
|
|
class TransactionUpdate(BaseModel):
|
|
account_id: int | None = None
|
|
category_id: int | None = None
|
|
transfer_account_id: int | None = None
|
|
type: TransactionType | None = None
|
|
amount: Decimal | None = Field(default=None, gt=0, max_digits=14, decimal_places=2)
|
|
description: str | None = Field(default=None, min_length=1, max_length=255)
|
|
merchant: str | None = Field(default=None, max_length=150)
|
|
notes: str | None = None
|
|
date: date_ | None = None
|
|
# Omitted -> tags untouched; sent (even as []) -> replaces the full tag set.
|
|
tag_ids: list[int] | None = None
|
|
|
|
@field_validator("description")
|
|
@classmethod
|
|
def _capitalize_description(cls, value: str | None) -> str | None:
|
|
return capitalize_first_letter(value) if value is not None else None
|
|
|
|
|
|
class TransactionRead(TransactionFields):
|
|
model_config = ConfigDict(from_attributes=True)
|
|
|
|
id: int
|
|
account: AccountRead
|
|
category: CategoryRead | None = None
|
|
tags: list[TagRead] = Field(default_factory=list)
|
|
|
|
|
|
class TransactionPage(BaseModel):
|
|
items: list[TransactionRead]
|
|
total: int
|
|
page: int
|
|
page_size: int
|
|
|
|
|
|
class TransactionBulkCreate(BaseModel):
|
|
"""CSV import (see routes/transactions.py's /bulk): the frontend parses
|
|
the file and maps its columns client-side, then sends already-shaped
|
|
rows here. All-or-nothing — same failure semantics as backup restore, so
|
|
a single bad row never leaves a partial import behind."""
|
|
|
|
items: list[TransactionCreate] = Field(min_length=1, max_length=5000)
|
|
|
|
|
|
class TransactionBulkCreateResult(BaseModel):
|
|
created: int
|